Skip to content

Add command to run multiple queries at once from file explorer#462

Merged
aeisenberg merged 4 commits intogithub:mainfrom
aeisenberg:aeisenberg/multi-run
Jun 22, 2020
Merged

Add command to run multiple queries at once from file explorer#462
aeisenberg merged 4 commits intogithub:mainfrom
aeisenberg:aeisenberg/multi-run

Conversation

@aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Jun 19, 2020

New command called codeQL.runQueries.

When invoked, gather all selected files and folders, and recursively search for ql files to run. Warn the user if a directory is selected. See comment inline for reason.

Fixes #459

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • @github/product-docs-dsp has been cc'd in all issues for UI or other user-facing changes made by this pull request.

@aeisenberg aeisenberg requested a review from jcreedcmu June 19, 2020 18:53
@aeisenberg
Copy link
Contributor Author

Ping @github/product-docs-dsp!

Changed the command name from "CodeQL: Run query" to "CodeQL: Run Queries in Selected Files". It is only available from the file explorer.

Recommend formatting and linting extension. Also, use 100 columns
for formatting.
New command called `codeQL.runQueries`.

When invoked, gather all selected files and folders, and recursively
search for ql files to run. Warn the user if a directory is selected.
See comment inline for reason.
@aeisenberg aeisenberg force-pushed the aeisenberg/multi-run branch from 964566a to 3624255 Compare June 22, 2020 15:16
Throw error if user tries to run more than that.
@aeisenberg aeisenberg force-pushed the aeisenberg/multi-run branch from 3624255 to 04f86c9 Compare June 22, 2020 15:23
Copy link
Contributor

@jcreedcmu jcreedcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, limiting this seems less than completely ideal, but seems like a fine compromise for now until we get more feedback. Figuring out either cancellation or at least making this limit configurable would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to run queries in bulk

2 participants