Swift: Drop support for plaintext diagnostics (and helpLinks). #13224
Merged
Swift: Drop support for plaintext diagnostics (and helpLinks). #13224
helpLinks). #13224Conversation
sashabu
force-pushed
the
sashabu/tsp-empty-help-links
branch
from
1b538b5 to
33cdbcd
Compare
sashabu
changed the title
helpLinks.helpLinks).
The recommended option is Markdown diagnostics, and we have already migrated everything to emit them. The empty help link we're currently emitting everywhere is a bug.
sashabu
force-pushed
the
sashabu/tsp-empty-help-links
branch
from
33cdbcd to
b3e76d6
Compare
MathiasVP
approved these changes
May 19, 2023
Contributor
MathiasVP
left a comment
MathiasVP
left a comment
There was a problem hiding this comment.
One comment (hopefully with a trivial answer 🤞), but otherwise LGTM!
swift/integration-tests/linux-only/autobuilder/unsupported-os/diagnostics.expected
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostics can include either a
plaintextMessageor amarkdownMessage. For plaintext messages, we can also includehelpLinks(whereas for Markdown, the links are embedded in the message). We're using Markdown everywhere, and I noticed all our helpLinks have a""as the only link. To "fix" that, this PR drops support forplaintextMessageandhelpLinksin the Swift extractor entirely.