Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Nov 3, 2025

It is already accounted for in the other path:

cpython/Objects/bytesobject.c

Lines 1049 to 1054 in b373d34

if (dict && (argidx < arglen)) {
PyErr_SetString(PyExc_TypeError,
"not all arguments converted during bytes formatting");
Py_XDECREF(temp);
goto error;
}

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 6, 2025
@kumaraditya303 kumaraditya303 merged commit d6c89a2 into python:main Nov 6, 2025
56 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @StanFromIreland and @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d6c89a2df2c8b7603125883494e9058a88348f66 3.14

@miss-islington-app
Copy link

Sorry, @StanFromIreland and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d6c89a2df2c8b7603125883494e9058a88348f66 3.13

@StanFromIreland StanFromIreland deleted the bytes-leak branch November 6, 2025 07:22
@StanFromIreland
Copy link
Member Author

I can backport.

@StanFromIreland StanFromIreland self-assigned this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants