Skip to content

Conversation

@mehrdadmoradii
Copy link
Contributor

@mehrdadmoradii mehrdadmoradii commented Sep 15, 2022

Adding documentation for the default dialect used by csv- starting from where #25989 (comment) left off.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 15, 2022
@terryjreedy terryjreedy changed the title gh-68335 Documenting csv Dialect class defaults gh-68335: Documenting csv Dialect class defaults Feb 5, 2024
@terryjreedy terryjreedy changed the title gh-68335: Documenting csv Dialect class defaults gh-68335: Documenting csv dialect defaults Feb 5, 2024
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dialects and Formatting Parameters section needs some work also.

EDIT: The reason the new text seems out of place (see above and resolved comment) is because it is. The original author,Brandon Milam ( jbmilam) of csv_dialect_doc_clarify.patch: "Document clarification" put it at the end of the first paragraph of the Dialects and Formatting Parameters section, as said in #68335 (comment), not at the end of the first paragraph of the class Dialect entry.

I am closing this and starting over.

@bedevere-app
Copy link

bedevere-app bot commented Feb 5, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants