JS: Remove totalorder() #20323
Merged
JS: Remove totalorder() #20323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was once as input to the shared data flow library, but has since been removed from the input signature.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the totalorder() method and related ordering functionality from the JavaScript dataflow library, as it's no longer required by the shared data flow library interface.
- Removes
totalorder()methods fromDataFlowCallable,DataFlowCall, andNodeRegionclasses - Eliminates the entire
TotalOrderingmodule and its associated helper predicates - Cleans up code that was previously used to provide ordering input to the shared data flow library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was once as input to the shared data flow library, but has since been removed from the input signature.