-
Notifications
You must be signed in to change notification settings - Fork 60.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update creating-a-docker-container-action.md #34085
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
|
@arivictor Thanks so much for opening a PR! I'll get this triaged for review ✨ |
|
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
|
@arivictor Thank you very much for your patience while our team reviewed! We will be accepting your changes ✨ Can you resolve the noted conflicts? Once that is finished, I'll update the branch and get this merged once tests are passing 🍏 |
Head branch was pushed to by a user without write access
Pull request was closed
|
Oops. Looks like this page doesn't exist anymore in the main branch anyway. all good. |
Why:
Despite following all the steps as per this guide, I encountered the below issue when testing my action:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Include a step in the example Dockerfile to make the
entrypoint.shexecutable in the container. Once I had added this my action worked without issue.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
datadirectory.For content changes, I have completed the self-review checklist.