gh-112281: Allow `Union` with unhashable `Annotated` metadata #112283

sobolevn · 2023-11-20T13:18:35Z

This should not affect performance that much:

I tried to keep the fast path as it is
Slow path is only used when TypeError happens on unhashable items (it should not affect code with only hashable parts)

Lib/typing.py

Lib/test/test_typing.py

Lib/typing.py

Lib/test/test_typing.py

Misc/NEWS.d/next/Library/2023-11-20-16-15-44.gh-issue-112281.gH4EVk.rst

Lib/typing.py

Lib/test/test_typing.py

Lib/test/test_types.py

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

Lib/test/test_typing.py

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

sobolevn · 2023-12-02T14:52:24Z

We just did 6 rounds of nitpicks :)

AlexWaygood

LGTM. @JelleZijlstra, anything more from you?

Lib/test/test_typing.py

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

pythongh-112281: Allow Union with unhashable Annotated metadata

c13aa09

sobolevn requested review from JelleZijlstra and AlexWaygood as code owners November 20, 2023 13:18

bedevere-app bot added the awaiting review label Nov 20, 2023

bedevere-app bot mentioned this pull request Nov 20, 2023

Unioned types should be hashable: not documented? #112281

Open

faph reviewed Nov 20, 2023

View reviewed changes

Lib/typing.py Outdated Show resolved Hide resolved

Add one more test case

0ff7f84

AlexWaygood reviewed Nov 20, 2023

View reviewed changes

Lib/test/test_typing.py Outdated Show resolved Hide resolved

sobolevn added 2 commits November 20, 2023 17:42

Fix ordering issues, use consistent hash check

d348b74

More tests

8dff1c4

JelleZijlstra reviewed Nov 25, 2023

View reviewed changes

Address review

968dd18