Minor updates to CodeQL for VS Code docs for expansion of support for model editing #15748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felicitymay
added
the
ready-for-doc-review
2 tasks
This was accidentally reintroduced during merge conflict resolution.
shati-patel
previously approved these changes
Feb 28, 2024
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Updates look good! 📝
(Minor side note—not from this PR, just looking at the preview: There's a .. tip:: box on this page which isn't really styled correctly. Might be worth changing that to a .. pull-quote:: to match the other boxes?)
subatoi
previously approved these changes
Feb 28, 2024
Contributor
subatoi
left a comment
subatoi
left a comment
There was a problem hiding this comment.
Thank you, particularly for updating the screenshots ❤️
felicitymay
dismissed stale reviews from subatoi and shati-patel
via
efff014
Contributor
Author
|
Thanks for the rapid reviews 💖 I've made the change @shati-patel requested, so this is probably ready to merge when one of you has time to give it a 👍🏻 |
subatoi
approved these changes
Feb 28, 2024
Contributor
subatoi
left a comment
subatoi
left a comment
There was a problem hiding this comment.
No reason to think CI won't pass 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only minor changes needed to the docs for the VS Code extension.
Reviewers, it would be great to get this merged before the next release candidate branch is created.