C#: Remove Stored variants of queries
#15629
Draft
+210
−257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `FlowSources` now re-exports `Remote`, these can be safely removed.
|
QHelp previews: |
| --- | ||
| category: majorAnalysis | ||
| --- | ||
| * The `Stored` variants of some queries (`cs/stored-command-line-injection`, `cs/web/stored-xss`, `cs/stored-ldap-injection`, `cs/xml/stored-xpath-injection`) have been removed. If you were using these queries, their results can be restored by enabling the `stored` threat model in your threat model settings. |
There was a problem hiding this comment.
settings -> configuration
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| category: majorAnalysis | |||
| --- | |||
| * The `Stored` variants of some queries (`cs/stored-command-line-injection`, `cs/web/stored-xss`, `cs/stored-ldap-injection`, `cs/xml/stored-xpath-injection`) have been removed. If you were using these queries, their results can be restored by enabling the `stored` threat model in your threat model settings. | |||
| * The `Stored` variants of some queries (`cs/stored-command-line-injection`, `cs/web/stored-xss`, `cs/stored-ldap-injection`, `cs/xml/stored-xpath-injection`) have been removed. If you were using these queries, their results can be restored by enabling the `local` threat model in your threat model settings. | |||
There was a problem hiding this comment.
local -> file and database. If local is added, other local sources will be added as well. We can recommend as a part of the change note to use local instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #15419. This removes the
Storedvariants of queries, as the results are now accessible by using thelocalthreat model.The affected queries are:
cs/stored-command-line-injectioncs/web/stored-xsscs/stored-ldap-injectioncs/xml/stored-xpath-injectionThis branch is currently based on #15419 in order to properly in the DCA run. The changes specific to this PR can be found here: 10077ba..780e034