Cpp non constant format as path query #15628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed dead comment
…cppnon-constant-format-alter-not-const-source
…cppnon-constant-format-alter-not-const-source # Conflicts: # cpp/ql/src/Likely Bugs/Format/NonConstantFormat.ql
…ttps://github.com/microsoft/codeql into 51-2cppnon-constant-format-alter-not-const-source
… We will test if this causes undesirable cases in DCA and then choose which approach is best.
…he output alert to be more precise on what is being alerted. Minor changes to the query itself to avoid redundancies with argv.
Co-authored-by: Mathias Vorreiter Pedersen <[email protected]>
…ttps://github.com/microsoft/codeql into 51-2cppnon-constant-format-alter-not-const-source
… cpp-non-constant-format-as-path-query # Conflicts: # cpp/ql/src/Likely Bugs/Format/NonConstantFormat.ql
…re accidentally removed in prior merge with other non-const branches)
MathiasVP
reviewed
Feb 19, 2024
| p = node.asParameter() and | ||
| // Ignore main's argv parameter as it is already considered a `FlowSource` | ||
| // not ignoring it will result in path redundancies | ||
| (f.getName() = "main" implies p.getName() != "argv") |
There was a problem hiding this comment.
This assumes the parameter is always called argv. That does not have to be true.
There was a problem hiding this comment.
Good point. I should've copied more verbatim what the current argv model is doing. I'll fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying the cpp non const format query to be a path query.