Swift: move keypath dataflow writes to fix types #14865
Open
+72
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
reviewed
Nov 21, 2023
Comment on lines
+266
to
+269
| exists(KeyPathExpr keyPath | | ||
| nodeFrom.(KeyPathComponentNodeImpl).getComponent() = keyPath.getComponent(keyPath.getNumberOfComponents() - 1) and | ||
| nodeTo.(KeyPathReturnNodeImpl).getKeyPathExpr() = keyPath | ||
| ) |
There was a problem hiding this comment.
Is the comment above this disjunct still correct now? It looks like this is now a step from the last component to the return, right?
Comment on lines
+276
to
+277
| // nodeFrom.(KeyPathComponentPostUpdateNode).getComponent() = | ||
| // nodeTo.(KeyPathParameterPostUpdateNode).getComponent(0) |
There was a problem hiding this comment.
Should probably be deleted now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the read and write steps on keypath nodes so that the component node is the destination of the read and source of the write, rather than being the source of the read and destination of the write. This means that the type of the dataflow node matches the type that the read/write implies, which will be important when type pruning is added.