C#: Also run extractor unit tests on a windows runner. #14333
Merged
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/windowsunittests
branch
6 times, most recently
from
ff2cb25
to
7544eb2
Compare
tamasvajk
reviewed
Sep 28, 2023
hvitved
reviewed
Sep 29, 2023
.github/workflows/csharp-qltest.yml
Outdated
| run: | | ||
| dotnet test -p:RuntimeFrameworkVersion=7.0.2 extractor/Semmle.Util.Tests | ||
| dotnet test -p:RuntimeFrameworkVersion=7.0.2 extractor/Semmle.Extraction.Tests | ||
| dotnet test -p:RuntimeFrameworkVersion=7.0.2 autobuilder/Semmle.Autobuild.CSharp.Tests | ||
| dotnet test -p:RuntimeFrameworkVersion=7.0.2 "${{ github.workspace }}/cpp/autobuilder/Semmle.Autobuild.Cpp.Tests" | ||
| unit-tests-windows: |
There was a problem hiding this comment.
I think you may be able to use a matrix (containing ubuntu-latest and windows-2019) to reduce duplication.
There was a problem hiding this comment.
Yes, that is a good idea (TIL). My skills for defining workflows are limited. As far as google informs me the default shell for all other types of runner than windows runners is bash, so setting the default to bash for non-windows test executions should also be fine.
michaelnebel
force-pushed
the
csharp/windowsunittests
branch
from
4fb5cf9
to
88c43dd
Compare
michaelnebel
force-pushed
the
csharp/windowsunittests
branch
from
9c6c91d
to
c25113a
Compare
tamasvajk
approved these changes
Sep 29, 2023
hvitved
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we