Swift: Fix bug in taint flow through string interpolation #14286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hmmm. I think the code structure on main is from a time when there was an issue with getQualifier and thus we were forced to write it like that. If this new code passes the tests I'm very happy to merge it as that is really what it's supposed to be doing 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in taint flow through string interpolation, where taint was flowing from input to other inputs (see the first commit for the demonstrative test).
@MathiasVP assuming the tests even pass, would you mind checking I'm not missing something here. It looks like it might've been done the way it was done for a reason (at least one that applied at the time).