Swift: CFG and data flow for nil coalescing operator #14224

rdmarsh2 · 2023-09-14T16:40:00Z

No description provided.

geoffw0

Fast work, and LGTM!

Probably deserves a short change note and a DCA run.

Lizzyrobin4

Ok approved

geoffw0 · 2023-09-18T08:53:21Z

The DCA run shows 4 lost results, on lines that use ?. but not ?? - though ?? is used earlier in the function. I've checked locally and this effect is real, and the direct cause is excluding NilCoalescingExpr from ApplyExprTree.

(there's also missing QLDoc in NilCoalescingExpr.qll)

rdmarsh2 added 3 commits September 14, 2023 13:26

Swift: AST and CFG tests for nil coalescing

dd01da4

Swift: CFG for nil coalescing operator

9a5fa42

Swift: update dataflow test for nil coalescing

ab7cd52

rdmarsh2 requested a review from a team as a code owner September 14, 2023 16:40

github-actions bot added the Swift label Sep 14, 2023

geoffw0 reviewed Sep 14, 2023

View reviewed changes

Swift: change note for nil-coalesing operator

2b54ad5

github-actions bot added the documentation label Sep 15, 2023

Lizzyrobin4 reviewed Sep 15, 2023

View reviewed changes

Swift: CFG and data flow for nil coalescing operator #14224

Swift: CFG and data flow for nil coalescing operator #14224

rdmarsh2 commented Sep 14, 2023

geoffw0 left a comment

Lizzyrobin4 left a comment

geoffw0 commented Sep 18, 2023

Swift: CFG and data flow for nil coalescing operator #14224

Are you sure you want to change the base?

Swift: CFG and data flow for nil coalescing operator #14224

Conversation

rdmarsh2 commented Sep 14, 2023

geoffw0 left a comment

Choose a reason for hiding this comment

Lizzyrobin4 left a comment

Choose a reason for hiding this comment

geoffw0 commented Sep 18, 2023