Rework the remaining inline expectation tests to use the parameterized module #13643
Conversation
![github-advanced-security[bot]](https://ssr-www.pages.dev/web/20260107073642im_/https://avatars.githubusercontent.com/in/57789?s=60&v=4&kwid=1tfa-bq%2560kjuf-lqd){kind=small}
These were missed earlier, and still referred to the classes from the legacy interface and not the parameterized module.
| module MakeFlowTest<FlowTestSig Impl> { | ||
| import MakeTest<FlowTest<Impl>> | ||
| } | ||
|
|
||
| module MakeFlowTest2<FlowTestSig Impl1, FlowTestSig Impl2> { | ||
| import MakeTest<MergeTests<FlowTest<Impl1>, FlowTest<Impl2>>> | ||
| } |
There was a problem hiding this comment.
I decided to drop this, and just use the bodies directly, as I find these are rather odd looking special cases. And to avoid having different point solutions both here and for RoutingTest below.
|
|
||
| class HttpServerHttpResponseTest extends InlineExpectationsTest { | ||
| File file; | ||
| abstract class DedicatedResponseTest extends string { |
There was a problem hiding this comment.
Note that this moves part of the functionality that first occurred in a number of individual tests to this shared file. I decided not to introduce another parameterized module that then needs to be instantiated, as that would affect many tests.
RasmusWL
left a comment
RasmusWL
left a comment
There was a problem hiding this comment.
Thanks so much ❤️ 🎉
I'll hold back from bike-shedding about how to do DedicatedResponseTest, since it doesn't really matter 😅
Thanks. I'd be curious to know though how you would have solved this. |
2 participants
Follow up to #12789, #13346, #13426, and #13498. This addresses the last remaining Python tests and deprecates the class-based interface.