Java: Add metric queries for counting sinks coming from models #13636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two queries for gathering metrics on the number of alerts (for a selection of queries) that arise from models with the `ai-generated` provenance.
While the string representation is useful for quickly modifying queries, it's a bit clunky when the data needs to be further parsed. Instead, the two queries now select all of the columns of the sinkmodel separately (which makes it easy to pull them out of the relevant output later on).
Also adds a more sensible ordering to the existing queries.
Exposes the same information as the existing queries through two query predicates instead. This makes the downstream data gathering a bit more convenient to implement.
kaeluka
previously approved these changes
Jul 14, 2023
kaeluka
left a comment
kaeluka
left a comment
There was a problem hiding this comment.
I just had a few superficial comments — LGTM, otherwise :)
|
@jhelie — I think it was |
Contributor
|
If those are improvements related to the MRVA metrics queries used in the work you've picked up, then yes I agree let's merge it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two queries for gathering metrics on the number of alerts (for a selection of queries) that arise from models with the
ai-generatedprovenance.Also adds
pragma[nomagic]to one of the utility predicates, as it would otherwise cause an inefficient join order to appear.