C#: Use synthetic global in the EntityFramework code instead of jump steps. #13147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/entityframeworkrefactor
branch
from
68a9fde
to
a9f795e
Compare
hvitved
reviewed
May 24, 2023
csharp/ql/lib/semmle/code/csharp/frameworks/EntityFramework.qll
Outdated
Show resolved
Hide resolved
michaelnebel
force-pushed
the
csharp/entityframeworkrefactor
branch
2 times, most recently
from
73ff0df
to
7542f6c
Compare
|
There appears to be a severe both cache and performance degradation for .NET EFCore with these changes. |
…es that uses synthetic globals.
…ork implementation.
michaelnebel
force-pushed
the
csharp/entityframeworkrefactor
branch
from
7542f6c
to
d882fe1
Compare
|
@hvitved : Ready for review. Thank you for the help with the performance issue! You were absolute right - we could just narrow the synthetic field names to the only absolutely necessary - that solved everything! |
hvitved
reviewed
Jun 13, 2023
csharp/ql/lib/semmle/code/csharp/frameworks/EntityFramework.qll
Outdated
Show resolved
Hide resolved
csharp/ql/lib/semmle/code/csharp/frameworks/EntityFramework.qll
Outdated
Show resolved
Hide resolved
csharp/ql/lib/semmle/code/csharp/frameworks/EntityFramework.qll
Outdated
Show resolved
Hide resolved
csharp/ql/lib/semmle/code/csharp/frameworks/EntityFramework.qll
Outdated
Show resolved
Hide resolved
csharp/ql/lib/semmle/code/csharp/frameworks/EntityFramework.qll
Outdated
Show resolved
Hide resolved
michaelnebel
force-pushed
the
csharp/entityframeworkrefactor
branch
2 times, most recently
from
f6dd979
to
6294e52
Compare
![github-code-scanning[bot]](https://ssr-www.pages.dev/web/20230620064429im_/https://avatars.githubusercontent.com/in/57789?s=60&v=4&kwid=1tfa-bq%2560kjuf-lqd){kind=small}
michaelnebel
force-pushed
the
csharp/entityframeworkrefactor
branch
from
6294e52
to
9690ff6
Compare
hvitved
reviewed
Jun 14, 2023
csharp/ql/lib/semmle/code/csharp/frameworks/EntityFramework.qll
Outdated
Show resolved
Hide resolved
There is a follow up for that: #13150 |
|
DCA still looks good. |
hvitved
approved these changes
Jun 14, 2023
michaelnebel
added
the
no-change-note-required
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In this PR we replace the use of jump steps with synthetic globals in the Entity Framework code.
The idea is that if we have a summary
for a callable
cwhere we have flow fromAtoBand whereBinvolves a jump step topthen we can replace this summary by two summariesHowever, it is important that
Sis unique for each target path of a summary to avoid collision.We can generate
Sbased on{p, B}to ensure that we avoid collisions (due to the global nature of synthetics).Some explanation of the new summaries.
Prior to the change there was a total of 116 summaries (as shown by the test).
After the change there is total of 143 summaries.
If we inspect the old summaries there are are total of 26 different target paths (all of them involving jumps to a property).
If we inspect the new summaries we see that there 26 summaries related to properties - each corresponding to a different target in the old summaries. Furthermore, the new summaries contain 116 summaries that write to the synthetics that the 26 properties read from. This should provide some justification that we have achieved equivalence.
DCA looks good.