Skip to content

delete old deprecations #13352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 7, 2023
Merged

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Jun 2, 2023

Not Python or C++ (except for files that are synchronized).
Those have complications, so they get their own PRs after this one has been merged.


Notes about change-notes:
C++: All changes seems to be in internal/ or implementation/ folders, so I don't think those need change-notes?
All: For most languages there were too many deleted classes/classes to reasonably list. So I went for a general note about using PascalCase instead of UPPERCASE.

@erik-krogh erik-krogh force-pushed the once-again-deps-not-py-cpp branch from 616e540 to ac9ede4 Compare June 2, 2023 09:58
@erik-krogh erik-krogh marked this pull request as ready for review June 2, 2023 12:08
@erik-krogh erik-krogh requested a review from a team June 2, 2023 12:08
@erik-krogh erik-krogh requested review from a team as code owners June 2, 2023 12:08
@jketema
Copy link
Contributor

jketema commented Jun 2, 2023

C++: All changes seems to be in internal/ or implementation/ folders, so I don't think those need change-notes?

Yeah, I think it's fine to not have a change note for these.

Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ 👍

Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# 👍

Copy link
Contributor

@alexrford alexrford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruby 👍

Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 👍

@erik-krogh erik-krogh merged commit 6ba7f9a into github:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants