-
Notifications
You must be signed in to change notification settings - Fork 1.7k
delete old deprecations #13352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete old deprecations #13352
Conversation
616e540 to
ac9ede4
Compare
Yeah, I think it's fine to not have a change note for these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C# 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ruby 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java 👍
Not Python or C++ (except for files that are synchronized).
Those have complications, so they get their own PRs after this one has been merged.
Notes about change-notes:
C++: All changes seems to be in
internal/orimplementation/folders, so I don't think those need change-notes?All: For most languages there were too many deleted classes/classes to reasonably list. So I went for a general note about using PascalCase instead of UPPERCASE.