-
Notifications
You must be signed in to change notification settings - Fork 1.9k
C#: Extract default parameter values. #13298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
michaelnebel
merged 3 commits into
github:main
from
michaelnebel:csharp/paramdefaultimplicitconversion
Jun 2, 2023
Merged
C#: Extract default parameter values. #13298
michaelnebel
merged 3 commits into
github:main
from
michaelnebel:csharp/paramdefaultimplicitconversion
Jun 2, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4bca664 to
bfe5ef9
Compare
…DefaultParameterValue attribute.
bfe5ef9 to
5f42b7c
Compare
5f42b7c to
83a8e3b
Compare
hvitved
previously approved these changes
Jun 1, 2023
Contributor
hvitved
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me 🎉
Contributor
|
Did you run DCA already? |
tamasvajk
previously approved these changes
Jun 1, 2023
csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/ImplicitCast.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
Not yet - but I will do so :-) |
Contributor
Author
|
DCA looks good! |
tamasvajk
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that there is yet another way, one can define a parameter default value by using the attribute (
DefaultParameterValue) to instruct the compiler, how the default value should be constructed using an implicit conversion operator.The following is valid C# code:
The compiler checks that there exists a way to construct (in this case an implicit conversion operator) a value of type
MyStructfrom astring.Intuitively, the definition of
Mis equivalent to (which is not legal C# code).In this PR we try to emulate this behaviour.