add syntax for signature definitions to QL specification #13222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginsbach
force-pushed
the
ginsbach/SignatureSyntax
branch
from
d48c803 to
6957857
Compare
cklin
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of https://github.com/github/codeql-core/issues/2452
I have taken inspiration from the section about modules for the basic structure.
Adding this grammar is a bit tricky, because it is quite far removed from how we actually do things in practice (see e.g. https://github.com/github/semmle-code/pull/46155). Similar to alias definitions, in reality, we folded the grammar rules for type signatures into class declarations, the grammar rules for predicate signatures into predicate declarations, and the grammar rules for module signatures into module declarations. We then disentangle them in
AntlrToQL. However, we don't want to expose this to the users.Therefore, the review should take into account that this grammar is essentially "made up" for the QL specification.