Skip to content

Conversation

@ginsbach
Copy link
Contributor

The specification was set up so that all rules that use lowerId, simpleId, upperId were introduced in the Identifier section (aside from qualId, which is introduced before in the section on Import directives). This meant that there was one convenient central place where users could look up the allowed identifier syntax for everything.

This PR restores this principle in two ways:

  1. Rules that previously circumvented some "redundant" redirections (such as type signatures using upperId directly rather than referring to classname) are changed to follow the existing behaviour of older rules.
  2. Rules moduleSignatureName, signatureExpr, and parameterName and are added to the Identifier section.

@ginsbach ginsbach changed the title update the **Identifier** section of the QL specification update the Identifier section of the QL specification May 22, 2023
@ginsbach ginsbach changed the title update the Identifier section of the QL specification repair and update the Identifier section of the QL specification May 22, 2023
@ginsbach ginsbach marked this pull request as ready for review May 22, 2023 11:09
@ginsbach ginsbach requested a review from a team as a code owner May 22, 2023 11:09
@ginsbach ginsbach requested a review from cklin May 22, 2023 11:09
@ginsbach ginsbach merged commit cff4317 into main May 22, 2023
@ginsbach ginsbach deleted the ginsbach/IdentifierSpecification branch May 22, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants