Skip to content

gh-84404: Add -fwrapv for new icc versions #19561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
furkanonder wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-84404: Add -fwrapv for new icc versions #19561

furkanonder wants to merge 3 commits into from

Conversation

@furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Apr 17, 2020 •
edited by bedevere-bot
Loading

@isidentical isidentical requested a review from skrah April 17, 2020 06:55
@csabella csabella requested review from skrah and removed request for skrah May 23, 2020 18:03
@furkanonder
Copy link
Contributor Author

furkanonder commented Jun 11, 2020

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Jun 11, 2020

Thanks for making the requested changes!

: please review the changes made to this pull request.

@skrah
Copy link
Contributor

skrah commented Jun 30, 2020

We need to check first whether icc supports -fwrapv. Not all versions do that.

Then, for consistency, set the WRAP variable like for the other compilers based on the result of the check.

@skrah
Copy link
Contributor

skrah commented Jun 30, 2020

And add a news entry, because most people here like that.

@furkanonder
Copy link
Contributor Author

furkanonder commented Aug 25, 2020 •
edited
Loading

Hi Stefan, I compiled successfully using icc 19.1.2 version. Now, the problem has been fixed. Can you review again?

@furkanonder furkanonder closed this by deleting the head repository Dec 23, 2022
@furkanonder furkanonder reopened this Dec 23, 2022
@furkanonder
Copy link
Contributor Author

furkanonder commented May 9, 2023

@skrah Ping

@corona10 corona10 self-assigned this May 9, 2023
@furkanonder furkanonder added the build The build process and cross-build label Aug 6, 2023
@furkanonder furkanonder changed the title bpo-40223: Add -fwrapv for new icc versions gh-84404: Add -fwrapv for new icc versions Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skrah skrah Awaiting requested review from skrah

Assignees

@corona10 corona10

Labels

awaiting change review build The build process and cross-build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@furkanonder @bedevere-bot @skrah @corona10 @the-knights-who-say-ni @ezio-melotti