Skip to content

JS: Modernize crypto libraries #12729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asgerf merged 3 commits into from
Apr 3, 2023
Merged

JS: Modernize crypto libraries #12729

asgerf merged 3 commits into from
Apr 3, 2023

Conversation

@asgerf
Copy link
Contributor

@asgerf asgerf commented Mar 31, 2023 •
edited
Loading

  • Use API graphs instead of local DataFlow
  • Use set literals
  • Prefer chaining over local variables in some cases

Evaluation was neutral.

@asgerf asgerf added JS Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish labels Mar 31, 2023
@asgerf asgerf force-pushed the js/crypto-modernize branch from b3e81cb to 64cf27a Compare March 31, 2023 12:49
@asgerf asgerf removed the Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish label Apr 3, 2023
@asgerf asgerf marked this pull request as ready for review April 3, 2023 07:46
@asgerf asgerf requested a review from a team as a code owner April 3, 2023 07:46
@asgerf asgerf added the no-change-note-required This PR does not need a change note label Apr 3, 2023
@asgerf asgerf merged commit 53de9ae into github:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erik-krogh erik-krogh erik-krogh approved these changes

Assignees

No one assigned

Labels

JS no-change-note-required This PR does not need a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asgerf @erik-krogh