Fail VSCE workflow on failure #2248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were ignoring errors coming from `vsce publish` and this was causing the workflow to succeed even when the publish failed. This will remove the `||` and let the workflow fail if the publish fails.
aeisenberg
approved these changes
Mar 29, 2023
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Makes sense. I don't think the message is particularly useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were ignoring errors coming from
vsce publishand this was causing the workflow to succeed even when the publish failed. This will remove the||and let the workflow fail if the publish fails.@aeisenberg I've requested your review because you originally added this step in #716, so you might have additional context on why this was necessary.
Checklist
ready-for-doc-reviewlabel there.