Skip to content

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Mar 10, 2023

If we have a flow summary for, say, a method that passes its first argument into the first parameter of its second argument:

input = Argument[0] and
output = Parameter[0].Argument[1]

and we are modeling the call-back as being passed into itself (as a self/this argument), then we are currently missing a post-update node for the implicit self argument. Adding this is relevant when modeling captured variable flow using field flow.

@hvitved hvitved force-pushed the dataflow/call-back-post-update branch from 84ab080 to 63221d6 Compare March 10, 2023 08:59
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Mar 10, 2023
@hvitved hvitved force-pushed the dataflow/call-back-post-update branch from 63221d6 to 32a699e Compare March 10, 2023 11:43
@hvitved hvitved marked this pull request as ready for review March 13, 2023 08:02
@hvitved hvitved requested review from a team as code owners March 13, 2023 08:02
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# Looks plausible to me.

Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I also tested locally with a small qltest. I'll put that up in a PR when this is merged.

@aschackmull aschackmull merged commit 0c95ab2 into github:main Mar 13, 2023
@hvitved hvitved deleted the dataflow/call-back-post-update branch March 13, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants