JS: recognize more express URL related sources #12518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
force-pushed
the
more-express-sources
branch
from
0a89291 to
a72436f
Compare
asgerf
reviewed
Mar 16, 2023
| ( | ||
| if exists(queryRef(request).getAPropertyRead()) | ||
| then this = queryRef(request).getAPropertyRead() | ||
| else this = queryRef(request) |
Contributor
There was a problem hiding this comment.
Suggested change
| else this = queryRef(request) | |
| else this = request.ref().getAPropertyRead("query") |
and similar for params (feel free to refactor to eliminate the duplication with queryRef).
Treating the result of the type-tracking predicate as a source can lead to redundant sources:
foo(req.query); // <-- 'req.query' is the correct source
function foo(query) {} // <-- 'query' becomes a redundant source
asgerf
approved these changes
Mar 16, 2023
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2022-2237: Recognize the source
I'm hoping the code is self-explanatory.
Evaluation was unevenful.