Ruby: improve diagnostic messages #12216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now we only report real parse errors and character encoding errors. Warnings about unexpected or missing nodes in the AST are not reported. These are typically side effects of earlier parse errors.
aibaars
force-pushed
the
diagnostics-2
branch
2 times, most recently
from
01d0f29
to
c4b0503
Compare
tausbn
reviewed
Feb 20, 2023
aibaars
force-pushed
the
diagnostics-2
branch
from
a2be8d8
to
f71c330
Compare
calumgrant
reviewed
Feb 20, 2023
ruby/extractor/src/extractor.rs
Outdated
| .severity(diagnostics::Severity::Error) | ||
| .location(self.path, start_line, start_column, end_line, end_column) | ||
| .text(&error_message) | ||
| .status_page(), | ||
| .message("unknown table type: {}", &[node.kind()]), |
There was a problem hiding this comment.
I notice an inconsistency in the capitalization of the message text - is there a convention or style guide to refer to about this?
aibaars
force-pushed
the
diagnostics-2
branch
2 times, most recently
from
cffdde3
to
91eba87
Compare
subatoi
previously approved these changes
Feb 28, 2023
erik-krogh
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.