Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix missing commas in signatures #23693

Merged
merged 2 commits into from Dec 22, 2020

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Dec 8, 2020

No description provided.

@andresdelfino andresdelfino changed the title [doc] Fix star in datetime signatures [doc] Fix missing commas Dec 8, 2020
@andresdelfino andresdelfino changed the title [doc] Fix missing commas [doc] Fix missing commas in signatures Dec 8, 2020
@andresdelfino andresdelfino requested a review from a team as a code owner Dec 8, 2020
@andresdelfino
Copy link
Contributor Author

andresdelfino commented Dec 22, 2020

@pganssle perhaps this can be merged?

@pganssle
Copy link
Member

pganssle commented Dec 22, 2020

@andresdelfino Oh sorry, I noticed that you were a "Member" of the Python org and assumed you had a commit bit so I figured you'd merge yourself, but now I see that triagers also show up as "Member". My mistake!

Merging now. Thanks!

@pganssle pganssle merged commit 60eccd0 into python:master Dec 22, 2020
3 checks passed
@bedevere-bot
Copy link

bedevere-bot commented Dec 22, 2020

@pganssle: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Dec 22, 2020

Thanks @andresdelfino for the PR, and @pganssle for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 22, 2020
* Fix star in signatures

* Fix comma in signatures
(cherry picked from commit 60eccd0)

Co-authored-by: Andre Delfino <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Dec 22, 2020

GH-23891 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 22, 2020
* Fix star in signatures

* Fix comma in signatures
(cherry picked from commit 60eccd0)

Co-authored-by: Andre Delfino <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Dec 22, 2020

GH-23892 is a backport of this pull request to the 3.8 branch.

@andresdelfino andresdelfino deleted the fix_star_signatures branch Dec 22, 2020
miss-islington added a commit that referenced this pull request Dec 29, 2020
* Fix star in signatures

* Fix comma in signatures
(cherry picked from commit 60eccd0)

Co-authored-by: Andre Delfino <[email protected]>
miss-islington added a commit that referenced this pull request Dec 29, 2020
* Fix star in signatures

* Fix comma in signatures
(cherry picked from commit 60eccd0)

Co-authored-by: Andre Delfino <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
* Fix star in signatures

* Fix comma in signatures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants