Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac #99406

Merged
merged 1 commit into from Nov 26, 2022
Merged

gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac #99406

merged 1 commit into from Nov 26, 2022

Conversation

thesamesam
Copy link
Contributor

@thesamesam thesamesam commented Nov 12, 2022 •
edited by bedevere-bot

…n fixes

Followup to 12078e7. I ended up missing a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is <stddef.h> for size_t.

See: 12078e7
Signed-off-by: Sam James sam@gentoo.org

@bedevere-bot bedevere-bot mentioned this pull request Nov 12, 2022
Closed
@thesamesam thesamesam force-pushed the more-clang16 branch 2 times, most recently from 741df47 to e7d69e1 Compare Nov 12, 2022
@thesamesam
Copy link
Contributor Author

thesamesam commented Nov 12, 2022

cc @erlend-aasland @kumaraditya303, followup from #99085.

Apologies for missing a few!

As penance, I'm going to do a followup now (but not generate configure yet as it won't be suitable to merge unless/until this is) in another PR for some AC_LANG_SOURCE porting (not doing it here to ease backporting).

@thesamesam thesamesam mentioned this pull request Nov 12, 2022
Draft
@thesamesam
Copy link
Contributor Author

thesamesam commented Nov 24, 2022

ping

@thesamesam
pythongh-99086: Further -Wstrict-prototypes, -Wimplicit-function-decl…
0ee1b0c 
…aration fixes

Followup to 12078e7. I ended up missing
a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default
and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes
while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is
<stddef.h> for size_t.

See: 12078e7
kumaraditya303
kumaraditya303 reviewed Nov 26, 2022
View changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Looks fine but I would like a review from @erlend-aasland

erlend-aasland
erlend-aasland approved these changes Nov 26, 2022
View changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Thanks, looks good to me! Sorry for the delay.

@kumaraditya303 kumaraditya303 changed the title gh-99086: Further -Wstrict-prototypes, -Wimplicit-function-declaratio… gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac Nov 26, 2022
@kumaraditya303 kumaraditya303 merged commit e35ca41 into python:main Nov 26, 2022
15 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Nov 26, 2022

Thanks @thesamesam for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Nov 26, 2022

Sorry, @thesamesam and @kumaraditya303, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e35ca417fe81a64985c2b29e863ce418ae75b96e 3.11

@miss-islington
Copy link
Contributor

miss-islington commented Nov 26, 2022

Sorry @thesamesam and @kumaraditya303, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker e35ca417fe81a64985c2b29e863ce418ae75b96e 3.10

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Nov 26, 2022

@thesamesam Can you create the backports? thanks

@thesamesam
Copy link
Contributor Author

thesamesam commented Nov 30, 2022

@kumaraditya303 Happy to, thanks folks!

@thesamesam thesamesam deleted the more-clang16 branch Nov 30, 2022
thesamesam added a commit to thesamesam/cpython that referenced this pull request Dec 1, 2022
@thesamesam
[3.11] pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-d…
f6faee9 
…eclaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7.
(cherry picked from commit e35ca41)
thesamesam added a commit to thesamesam/cpython that referenced this pull request Dec 1, 2022
@thesamesam
[3.11] pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-d…
e9f27cd 
…eclaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7.
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this pull request Dec 1, 2022
@thesamesam
[3.11] pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-d…
5fbd168 
…eclaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7..
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>
@thesamesam thesamesam mentioned this pull request Dec 1, 2022
Merged
@bedevere-bot
Copy link

bedevere-bot commented Dec 1, 2022

GH-99919 is a backport of this pull request to the 3.11 branch.

@thesamesam thesamesam mentioned this pull request Dec 1, 2022
Merged
@bedevere-bot
Copy link

bedevere-bot commented Dec 1, 2022

GH-99920 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

bedevere-bot commented Dec 1, 2022

GH-99920 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit that referenced this pull request Dec 1, 2022
@thesamesam
[3.11] gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declara… (
88b754b 
GH-99919)

…tion warnings in configure.ac (GH-99406)

Follow up to 12078e7. (cherry picked from commit e35ca41)
kumaraditya303 pushed a commit that referenced this pull request Dec 1, 2022
@thesamesam
[3.10] GH-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declara… (
807b103 
#99920)

[3.10] gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac (GH-99406)

Follow up to 12078e7.
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland

@kumaraditya303 kumaraditya303

Assignees

@kumaraditya303 kumaraditya303

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thesamesam @miss-islington @kumaraditya303 @bedevere-bot @erlend-aasland