Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30790: fix proxy works uncorrectly if registry value end with a semicolon #2611

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cordius
Copy link

@Cordius Cordius commented Jul 7, 2017

The function proxy_bypass_registry will return 1 if registry value end
with a semicolon because a NULL string will be contained in the variable
proxyOverride while using proxyOverride.split(';'). And therefore, our
proxy will never work correctly.

The function proxy_bypass_registry will return 1 if registry value end
with a semicolon because a NULL string will be contained in the variable
proxyOverride while using proxyOverride.split(';'). And therefore, our
proxy will never work correctly.
auvipy
auvipy approved these changes Jun 2, 2019
@csabella
Copy link
Contributor

csabella commented May 29, 2020

@Cordius, please take a look at the comments on the bug tracker issue.

@github-actions
Copy link

github-actions bot commented Feb 20, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 20, 2022
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 28, 2022
@github-actions
Copy link

github-actions bot commented Aug 29, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 29, 2022
Copy link
Member

@iritkatriel iritkatriel left a comment

As was mentioned on the issue, a change like this requires a unit test that reproduces the bug being fixed.

@bedevere-bot
Copy link

bedevere-bot commented Dec 7, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants