C++: Model getaddrinfo as flow source
#11627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://ssr-www.pages.dev/web/20260102023549im_/https://avatars.githubusercontent.com/in/57789?s=60&v=4&kwid=1tfa-bq%2560kjuf-lqd){kind=small}
MathiasVP
approved these changes
Dec 9, 2022
Contributor
MathiasVP
left a comment
MathiasVP
left a comment
There was a problem hiding this comment.
This LGTM!
I wasn't quite sure whether this should be a remote or local source. I picked remote, as
getaddrinfomay involve a network lookup.
I think that's the right choice. We've had similar discussions with flow sources that are functions which take a file-descriptor argument (since that can be both a local file or a network socket). And for those, I seem to recall that we defaulted to making these remote flow sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the flow sources on par with
isUserInputI wasn't quite sure whether this should be a remote or local source. I picked remote, as
getaddrinfomay involve a network lookup.Disappointingly no new DCA results, contrary to the previous two PRs.