Ruby: Add additional sinks to the rb/kernel-open query
#11366
+94
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi!
This PR adds following sinks to the
rb/kernel-openquery:IO.writeIO.binreadIO.binwriteIO.foreachIO.readlinesURI.openThese sinks all belong to the same family as the already implemented
Kernel.openandIO.read. (Command injection with a starting pipe (|).In addition to that I added a sanitizer I encountered in the wild:
File.joinsanitizes an untrusted user input if the tainted data is not passed in as the first argument (command execution is only possible if the first sign character passed to those sinks is a pipe (|).