Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asyncio experts (Kumar Aditya, Thomas Grainger, Guido) #966

Merged
merged 1 commit into from Oct 10, 2022

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Oct 10, 2022

Will this tell a bot to assign us asyncio issues?

@gvanrossum gvanrossum changed the title Add asyncio experts (Kumar, GraingerT, myself) Add asyncio experts (Kumar Aditya, Thomas Grainger, Guido) Oct 10, 2022
@hugovk
Copy link
Member

hugovk commented Oct 10, 2022

No, this file is for humans, and you can also add an asterisk to indicate it's okay to assign such issues to you:

Unless a name is followed by a '*', you should never assign an issue to
that person. Names followed by a '*' may be assigned issues involving the
module or topic.

To be auto-assigned PRs, you can update the names the CODEOWNERS file, which will assign based on modified files:

https://github.com/python/cpython/blob/ad817cd5c44416da3752ebf9baf16d650703275c/.github/CODEOWNERS#L11

@ezio-melotti
Copy link
Member

ezio-melotti commented Oct 10, 2022

You can subscribe to labels to get notified, but I don't think we have any automation to assign issues anymore.
For PRs there is CODEOWNERS (you are already listed).

hugovk
hugovk approved these changes Oct 10, 2022
@@ -62,7 +62,7 @@ argparse
array
ast benjaminp, pablogsal, isidentical
asynchat josiahcarlson, giampaolo*, stutzbach^
asyncio 1st1, asvetlov
asyncio 1st1, asvetlov, gvanrossum, graingert, kumaraditya303
Copy link
Member

@ezio-melotti ezio-melotti Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
asyncio 1st1, asvetlov, gvanrossum, graingert, kumaraditya303
asyncio 1st1, asvetlov, gvanrossum*, graingert, kumaraditya303

You can an * after your name to indicate that you are fine with the issue being assigned to you.

Copy link
Member Author

@gvanrossum gvanrossum Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I am not. I read everything and then decide.

@gvanrossum gvanrossum merged commit 05f6d0c into main Oct 10, 2022
4 checks passed
@gvanrossum gvanrossum deleted the gvanrossum-asyncio-experts branch Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants