RB: change the summary for reject() to always flow to the first block parameter #10695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets a TP/TN for CVE-2021-31799 (together with #10680).
The summary for
reject()would propagate flow from array-elements to the last parameter of the block.However, the
reject()method on Arrays always sends those elements to the first parameter.In the vast majority of cases that is not an issue (there is usually exactly one parameter when
rejectis used with arrays).But that is not the case in rdoc.
I will take a look all the other flow-summaries for arrays that use the
lastBlockParam()utility predicate.But only after I get a 👍 on how I've changed
reject().So this PR is ready-for-review, but not ready-for-merge.