Swift: implement DataFlowDispatch for closures #9627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdmarsh2
force-pushed
the
rdmarsh2/swift/dataflow-dispatch-1
branch
from
8144db3
to
7056db1
Compare
MathiasVP
reviewed
Jun 21, 2022
|
|
||
| predicate bigStep(Node start, Node end) { | ||
| // TODO: restrict to interesting starts? | ||
| start = end |
There was a problem hiding this comment.
Yeah, I think this relation will be way too big as-is. If the compiler isn't adding any magic here, this is essentially the transitive closure of the entire local flow step relation.
I think we can avoid a bunch of this manual transitive closure stuff by instead implementing lambdaCreation and lambdaCall similar to how it's done in Ruby: https://github.com/github/codeql/blob/main/ruby/ql/lib/codeql/ruby/dataflow/internal/DataFlowPrivate.qll#L1084.
There was a problem hiding this comment.
I went ahead and implemented that, passing the same set of tests, but there's almost no overlap in the code. I've opened a separate PR: #9669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.