Swift: More improvements to swift/string-length-conflation #9773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift/ql/src/queries/Security/CWE-135/StringLengthConflation.ql
Outdated
Show resolved
Hide resolved
MathiasVP
approved these changes
Jul 1, 2022
Contributor
MathiasVP
left a comment
MathiasVP
left a comment
There was a problem hiding this comment.
LGTM! Indeed, what you write here:
Notably for the String and String.Index member functions, I can't find a way of checking the associated class is correct (i.e. that we're looking at a call to String.index not foo.index). While this would be nice to have, in practice since we match on the argument and parameter names as well, so I think false positives are unlikely.
is something we have to provide a better API for. Let's get this merged now so that it doesn't fall between the cracks as we're going on vacation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More improvements to
swift/string-length-conflation:String->NSStringdirection is now detected 🎉*,/)Notably for the
StringandString.Indexmember functions, I can't find a way of checking the associated class is correct (i.e. that we're looking at a call toString.indexnotfoo.index). While this would be nice to have, in practice since we match on the argument and parameter names as well, so I think false positives are unlikely.