QL: followup fixes to parameterized modules #9593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
force-pushed
the
param2
branch
2 times, most recently
from
1cd91e9 to
cfd14e9
Compare
… resolve to a module
![github-advanced-security[bot]](https://ssr-www.pages.dev/web/20260107112738im_/https://avatars.githubusercontent.com/in/57789?s=60&v=4&kwid=1tfa-bq%2560kjuf-lqd){kind=small}
tausbn
previously approved these changes
Jul 12, 2022
Contributor
tausbn
left a comment
tausbn
left a comment
There was a problem hiding this comment.
Nice work! All of the changes look good to me. 👍
Contributor
Author
|
Merged with |
tausbn
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup PR to #9575
The
only resolve module types ...mistake was caught by a test-case in my patching utility.Lots of changes.
Now every call has one, and only one, target! (Except for some cases laid out in the consistency test).
There were a whole bunch of small bugs that caused us to spuriously resolve too many predicates.