Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

venv bug: Function “_old_fish_prompt” does not exist when activating venv in child process #93858

Closed
thomasbbrunner opened this issue Jun 15, 2022 · 1 comment · Fixed by #93931
Closed

venv bug: Function “_old_fish_prompt” does not exist when activating venv in child process #93858

thomasbbrunner opened this issue Jun 15, 2022 · 1 comment · Fixed by #93931
Assignees
@vsajip
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@thomasbbrunner
Copy link
Contributor

thomasbbrunner commented Jun 15, 2022 •
edited

Bug report

Looked for similar issues and could not find any.

Steps to reproduce bug:

  1. activate venv
  2. spawn child fish process (or start tmux session)
  3. activate same venv
source activate.fish
fish
source activate.fish

Should output:
functions: Function “_old_fish_prompt” does not exist

Cause

I think I've identified the reason for the bug:

  1. The environment variables set in activate.fish are exported to child processes (script uses set -gx to set the variables).
  2. However, the function _old_fish_prompt is not exported to child processes.

So, when we run fish from another fish session (such as in tmux), the variables set in activate.fish are present in the child process, but the functions are not.

Fix

I've written a fix for this, which is to test if the _old_fish_prompt function exists before attempting to delete it. I can make a PR with this fix.

Also, the implementation from virtualenv does not suffer from this bug. They check if the function exists before deleting it.

Your environment

Ubuntu 22.04 amd64
Python 3.10.4
Python and venv packages installed from apt
@thomasbbrunner thomasbbrunner added the type-bug An unexpected behavior, bug, or error label Jun 15, 2022
@thomasbbrunner thomasbbrunner mentioned this issue Jun 15, 2022
Open
@AlexWaygood AlexWaygood added the stdlib Python modules in the Lib dir label Jun 15, 2022
@vsajip
Copy link
Member

vsajip commented Jun 15, 2022

I can make a PR with this fix.

Please do, and thanks for the report.

@thomasbbrunner thomasbbrunner mentioned this issue Jun 17, 2022
Merged
vsajip pushed a commit that referenced this issue Jun 27, 2022
@thomasbbrunner
gh-93858: Prevent error when activating venv in nested fish instances (…
1172172 
…GH-93931)
This was referenced Oct 18, 2022
Merged
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 18, 2022
@thomasbbrunner @miss-islington
pythongh-93858: Prevent error when activating venv in nested fish ins…
ce30c70 
…tances (pythonGH-93931)

(cherry picked from commit 1172172)

Co-authored-by: Thomas B. Brunner <thomasbbrunner@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 18, 2022
@thomasbbrunner @miss-islington
pythongh-93858: Prevent error when activating venv in nested fish ins…
b9f265a 
…tances (pythonGH-93931)

(cherry picked from commit 1172172)

Co-authored-by: Thomas B. Brunner <thomasbbrunner@gmail.com>
vsajip pushed a commit that referenced this issue Oct 18, 2022
@miss-islington @thomasbbrunner
[3.11] gh-93858: Prevent error when activating venv in nested fish in…
11e1ed0 
…stances (GH-93931) (GH-98402)

Co-authored-by: Thomas B. Brunner <thomasbbrunner@gmail.com>
vsajip pushed a commit that referenced this issue Oct 18, 2022
@miss-islington @thomasbbrunner
[3.10] gh-93858: Prevent error when activating venv in nested fish in…
ce87ab4 
…stances (GH-93931) (GH-98403)

Co-authored-by: Thomas B. Brunner <thomasbbrunner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsajip vsajip

Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-93858: Prevent error when activating venv in nested fish instances (GH-93931)
3 participants
@vsajip @thomasbbrunner @AlexWaygood