IDLE maxosc.overrideRootMenu: remove unused menudict

[terryjreedy]

BPO	33964
Nosy	@terryjreedy, @csabella
PRs	bpo-33964: IDLE macosx - removed unused local dict. #7926
Dependencies	bpo-33963: IDLE macosx: add tests.

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = None
created_at = <Date 2018-06-26.04:01:56.869>
labels = ['expert-IDLE', '3.7', '3.8', 'performance']
title = 'IDLE maxosc.overrideRootMenu: remove unused menudict'
updated_at = <Date 2019-03-20.19:52:30.187>
user = 'https://github.com/terryjreedy'

bugs.python.org fields:

activity = <Date 2019-03-20.19:52:30.187>
actor = 'cheryl.sabella'
assignee = 'terry.reedy'
closed = False
closed_date = None
closer = None
components = ['IDLE']
creation = <Date 2018-06-26.04:01:56.869>
creator = 'terry.reedy'
dependencies = ['33963']
files = []
hgrepos = []
issue_num = 33964
keywords = ['patch']
message_count = 2.0
messages = ['320470', '338509']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'cheryl.sabella']
pr_nums = ['7926']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue33964'
versions = ['Python 3.7', 'Python 3.8']

[terryjreedy]

Function local name 'menudict' is initialized empty, two key value pairs are added, and it is never touched again.

[csabella]

Since there's a self.menudict in the editor, I wonder if this was intended for that. The self.menudict is used in ApplyKeyBindings, which is called when the key bindings change in configdialog. So, if the mac OS menu isn't added to self.menudict, does that mean that the Mac key bindings aren't updated?

[terryjreedy]

Need to check if above reveals a bug. Key bindings on macOS are somewhat flakey.