Update README.md #22
Merged
Update README.md #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timeyoutakeit
reviewed
Nov 16, 2021
README.md
Outdated
| Press the `.` key on any repository or pull request, or swap `.com` with `.dev` in the URL, to go directly to a VS Code environment in your browser. | ||
|
|
||
| To get started coding and adding files, try out the `.` key on any of your repos or PRs. You can also check out [http://github.dev/microsoft/vscode](http://github.dev/microsoft/vscode) as an example of github.dev in action. |
There was a problem hiding this comment.
This and line 5 are pretty similar. Could we just expand both of them like:
There are two ways to go directly to a VS Code environment in your browser and start coding:
- Press the
.key on any repository or pull request. - Swap
.comwith.devin the URL. For example, for this repo https://github.com/github/dev becomes http://github.dev/github/dev
I'm also wondering if most people are seeing this readme in the github.dev environment. In which case we probably don't want to confuse them too much by linking to another github.dev repo.
There was a problem hiding this comment.
Thanks @timeyoutakeit! Your feedback makes sense. I updated with the wording you suggested.
timeyoutakeit
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Based on feedback, looking to add some additional content and an example github.dev link to the readme.
@timeyoutakeit @matthewisabel @martinwoodward if you have other wording ideas, would love to discuss! Want to ensure folks who end up here (i.e. hear about github.dev and just go to
github.devin the browser, click ongithub.devfrom a hyperlink when it's discussed online) understand what the tool is and how they can move to using it on their own repos.