bpo-34098: multiprocessing.Server now uses ExceptionWithTraceback

[gsalgado]

That way we preserve the original traceback, and make debugging easier

Closes: https://bugs.python.org/issue34098

Note to self: use ./python -m unittest -v test.test_multiprocessing_fork.WithManagerTestMyManager to run the tests

https://bugs.python.org/issue34098

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

[gsalgado]

I've signed the CLA and it's been processed already. Can somebody remove the CLA not signed label?

[pablogsal]

Hi @gsalgado and thank you for your contribution! Could you add a NEWS entry using the blurb tool as described here? Thanks!

[gsalgado]

NEWS entry added, @pablogsal

[pablogsal]

@gsalgado Thanks! As a general note, please, do not squash/amend the commits as is easier to check individual changes than a big commit when reviewing. The Pull Request will be squashed when merged (squash and merge) so it does not matter that much to preserve commit hygiene in the PR itself (although it helps when reviewing).

[pablogsal]

Please, use method when formatting classes and such. For example:

Fix warning message when os.chdir() fails inside
test.support.temp_cwd(). Patch by Chris Jerdonek.

Also, add a colon at the end of the line. :)

[gsalgado]

@pablogsal done. used double backticks like I've found in other NEWS entries

[pablogsal]

Please add "Patch by Guilherme Salgado" at the end. :)

[gsalgado]

I'd forgotten this was still open... Any chance somebody can review it?

[pitrou]

Thanks for the PR. Here are some comments about the proposed changes.

[pitrou]

Why don't you simply call foo.g here? Is _callmethod doing something special?

[gsalgado]

I don't remember, really, but foo.g() seems to work as well, so I'll change it

[pitrou]

Instead of testing low-level details, how about something pertaining to the user's experience?
For example you could have:

class FooBar(object):
    def f(self):
        return 'f()'
    def g(self):
        raise ValueError  # exception raised here
    def _h(self):
        return '_h()'

And then self.assertIn('# exception raised here', str(cause)).

[gsalgado]

Sounds good, but should I drop the self.assertIsInstance(cause, multiprocessing.pool.RemoteTraceback) check, then?

[pitrou]

Also, since this PR is a bit old, can you merge/rebase master into it?

[gsalgado]

Also, since this PR is a bit old, can you merge/rebase master into it?

Done

[MaxwellDupre]

Example given:
Ran 3 tests in 0.360s
OK
Ran test_multi*
Ran 345 tests in 183.352s
OK (skipped=32)
Ran 39 tests in 21.005s
OK
Ran 345 tests in 79.499s
OK (skipped=33)
Ran 345 tests in 92.366s
OK (skipped=29)
Looks ok.

[github-actions]

This PR is stale because it has been open for 30 days with no activity.