gh-870 Added Closing PR section for close reasons #877
Conversation
where now we can opt to close as complete or not-planned. GH issue: python#870 GH blog: https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/
I'm not sure it's worth mentioning the blog entry and the date it was published. Maybe we don't even need a separate section and the two options can be mentioned elsewhere, even though this is a new feature and a separate section might make it more noticeable.
za
changed the title
za
changed the title
|
Hi @ezio-melotti I've updated the PR. Please check again. Thank you. |
Actually I just noticed that this is in the "Lifecycle of a pull request" page, but the closing reason only seem to apply to issues -- not pull requests. Pull requests can only be merged or closed.
Maybe it can be mentioned in the tracker.rst page instead?
because the closed reason is for issues and not for pull request.
PR updated! |
where now we can opt to close as complete or not-planned.
GH issue: #870
GH blog:
https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/