Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote usage of close reasons #870

Closed
erlend-aasland opened this issue May 19, 2022 · 3 comments
Closed

Promote usage of close reasons #870

erlend-aasland opened this issue May 19, 2022 · 3 comments

Comments

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 19, 2022

GitHub released new features for issues today: https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/

It is now possible to close as completed, or close as not planned (won't fix, no repro, invalid, etc.). It is possible to filter searches using reason:completed and reason:"not planned".

Suggesting to promote usage of closing reasons in the devguide.

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented May 21, 2022

There is no need to resolve this until the triage section has been rewritten with regards to the new GitHub Issues workflow.

za added a commit to za/devguide that referenced this issue Jun 2, 2022
where now we can opt to close as complete or not-planned.

GH issue: python#870
GH blog:
https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/
ezio-melotti pushed a commit that referenced this issue Jun 5, 2022
* Added Closing PR section

where now we can opt to close as complete or not-planned.

GH issue: #870
GH blog:
https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/

* Remove new section and remove github blog hyperlink.

* Modify tracker.rst and restore pullrequest.rst

because the closed reason is for issues and not for pull request.
@za
Copy link
Contributor

@za za commented Jun 6, 2022

As the PR has been merged, can we close/resolve this issue now @ezio-melotti ?

@za
Copy link
Contributor

@za za commented Jun 6, 2022

Thanks @ezio-melotti I'll add keyword in the next PR so once PR has been merged, the issue will automatically closed.

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants