New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-92859: Doc: add info about logging.debug() calling basicConfig() #93063
base: main
Are you sure you want to change the base?
Conversation
This adds some info about logging.debug() (and other level functions) calling basicConfig() on behalf of the user if logging wasn't configured beforehand.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
| @@ -242,6 +242,10 @@ is the module's name in the Python package namespace. | |||
| above example). In such circumstances, it is likely that specialized | |||
| :class:`Formatter`\ s would be used with particular :class:`Handler`\ s. | |||
|
|
|||
| If no handler is attached to this logger (or its parents if | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps change to
If no handler is attached to this logger (or any of its ancestors,
taking into account the relevant :attr:`Logger.propagate` attributes),
the message will be sent ...
| @@ -1038,6 +1042,9 @@ functions. | |||
| above example). In such circumstances, it is likely that specialized | |||
| :class:`Formatter`\ s would be used with particular :class:`Handler`\ s. | |||
|
|
|||
| The function will call :func:`basicConfig` if the root logger doesn't have | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to
This function (as well as :func:`info`, :func:`warning`, :func:`error` and :func:`critical`) will call ...
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This adds some info about logging.debug() (and other level functions)
calling basicConfig() on behalf of the user if logging wasn't configured
beforehand.
#92859