bpo-45692: Improve support of non-ASCII identifiers in IDLE #29381
+27
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is a draft. Needed tests. |
serhiy-storchaka
reviewed
Nov 3, 2021
| @@ -14,13 +14,6 @@ | |||
| # all ASCII chars that may be the first char of an identifier | |||
| _ASCII_ID_FIRST_CHARS = frozenset(string.ascii_letters + "_") | |||
|
|
|||
| # lookup table for whether 7-bit ASCII chars are valid in a Python identifier | |||
There was a problem hiding this comment.
_IS_ASCII_ID_CHAR[ord(c)] is slower than c in _ASCII_ID_CHARS.
| while i > 0 and line[i-1] in self.wordchars: | ||
| i = i-1 | ||
| return line[i:] | ||
| m = _LAST_WORD_RE.search(line) |
There was a problem hiding this comment.
Need to test with long lines.
|
This PR is stale because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
https://bugs.python.org/issue45692
The text was updated successfully, but these errors were encountered: