Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92898: Enhance _testcppext test on cast to PyObject* #93111

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-92898: Enhance _testcppext test on cast to PyObject* #93111

wants to merge 2 commits into from
+56 −36

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 23, 2022

  • Add StrongRef class.
  • Rename and reformat functions of the _Py_CAST() implementation.

@vstinner
pythongh-92898: Enhance _testcppext test on cast to PyObject*
b5cf8b6 
* Add StrongRef class.
* Rename and reformat functions of the _Py_CAST() implementation.
@vstinner
Copy link
Member Author

@vstinner vstinner commented May 23, 2022

I'm not sure that having a separated _Py_STATIC_CAST() macro is still needed with the new _Py_CAST() implementation. Maybe _Py_STATIC_CAST() can now be replaced with _Py_CAST().

@vstinner
Copy link
Member Author

@vstinner vstinner commented May 23, 2022

I added a NEWS entry for #92951 change, since at least greenlet and scipy were impacted by C++ compiler warnings with Python 3.11 beta1.

@vstinner vstinner mentioned this pull request May 23, 2022
Merged
@vstinner
Copy link
Member Author

@vstinner vstinner commented May 23, 2022

cc @serge-sans-paille @corona10 @erlend-aasland @tacaswell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting core review needs backport to 3.11 skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vstinner @bedevere-bot