gh-93065: Fix HAMT to iterate correctly over 7-level deep trees #93066
+53
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
vstinner
reviewed
May 22, 2022
|
Hey @1st1 as I found and fixed this bug (MagicStack/immutables#85) can I open this PR? I'd really like to have a merge in CPython on my name. |
Co-authored-by: Yury Selivanov <[email protected]>
|
@molaxx Eli, the commit is a bit more involved now as I added a comment explaining the fix + a test. I'd prefer to keep this PR and merge it. That said, this change is yours, so I changed the author of the commit to your name and also added you to Misc/ACKS. Now since you're the author, you need to accept our CLA here: #93066 (comment) |
|
@1st1 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.