Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92112: Fix crash triggered by an evil custom mro() #92113

Merged
merged 1 commit into from May 6, 2022
Merged

gh-92112: Fix crash triggered by an evil custom mro() #92113

merged 1 commit into from May 6, 2022

Conversation

izbyshev
Copy link
Contributor

@izbyshev izbyshev commented May 1, 2022

No description provided.

@izbyshev izbyshev requested a review from markshannon as a code owner May 1, 2022
@AlexWaygood AlexWaygood added the type-crash label May 1, 2022
@izbyshev izbyshev mentioned this pull request May 1, 2022
Closed
@JelleZijlstra JelleZijlstra self-assigned this May 3, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.9 needs backport to 3.10 🔨 test-with-buildbots labels May 4, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 5, 2022

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 616024e 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label May 5, 2022
@JelleZijlstra JelleZijlstra merged commit 85354ed into python:main May 6, 2022
80 of 86 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 6, 2022

Thanks @izbyshev for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 6, 2022

Sorry, @izbyshev and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 85354ed78c0edb6d81a2bd53cabc85e547b8b26e 3.10

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 6, 2022

Sorry @izbyshev and @JelleZijlstra, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 85354ed78c0edb6d81a2bd53cabc85e547b8b26e 3.9

JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this issue May 6, 2022
@izbyshev @JelleZijlstra
[3.10] pythongh-92112: Fix crash triggered by an evil custom mro() (p…
078e034 
…ythonGH-92113).

(cherry picked from commit 85354ed)

Co-authored-by: Alexey Izbyshev <[email protected]>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 6, 2022

GH-92370 is a backport of this pull request to the 3.10 branch.

JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this issue May 6, 2022
@izbyshev @JelleZijlstra
[3.9] pythongh-92112: Fix crash triggered by an evil custom mro() (p…
2a420e9 
…ythonGH-92113).

(cherry picked from commit 85354ed)

Co-authored-by: Alexey Izbyshev <[email protected]>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 6, 2022

GH-92372 is a backport of this pull request to the 3.9 branch.

JelleZijlstra added a commit that referenced this issue May 7, 2022
@JelleZijlstra @izbyshev
[3.10] gh-92112: Fix crash triggered by an evil custom mro() (GH-92113
4674b31 
) (#92370)

(cherry picked from commit 85354ed)

Co-authored-by: Alexey Izbyshev <[email protected]>
@JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented May 11, 2022

Ooohhhh you fixed it! Thanks @izbyshev! It was the following item on my todo-list, and woosh, already fixed!

Out of curiosity, how did you discovered the issue?

@izbyshev
Copy link
Contributor Author

@izbyshev izbyshev commented May 11, 2022

You're welcome, @JulienPalard :)

Out of curiosity, how did you discovered the issue?

Nothing smart, unfortunately. I was trying to investigate a couple of mysterious non-reproducible Python crashes on a CI box at work, which occurred in Py_DECREF of a string. In one case, the string was the attribute name cached in the method cache, so I decided to take a look at Objects/typeobject.c and stumbled upon this bug (unrelated to my problem).

ambv pushed a commit that referenced this issue May 16, 2022
@JelleZijlstra @izbyshev
[3.9] gh-92112: Fix crash triggered by an evil custom mro() (GH-92113…
f82b324 
…) (GH-92372)

(cherry picked from commit 85354ed)

Co-authored-by: Alexey Izbyshev <[email protected]>
hello-adam pushed a commit to hello-adam/cpython that referenced this issue Jun 2, 2022
@JelleZijlstra @izbyshev @hello-adam
[3.9] pythongh-92112: Fix crash triggered by an evil custom mro() (p…
0562a9e 
…ythonGH-92113) (pythonGH-92372)

(cherry picked from commit 85354ed)

Co-authored-by: Alexey Izbyshev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra

@markshannon markshannon

Assignees

@JelleZijlstra JelleZijlstra

Labels
type-crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@izbyshev @bedevere-bot @miss-islington @JulienPalard @JelleZijlstra @AlexWaygood