Add support for bad url locations #198
Merged
Conversation
|
awesome thank you @huangsam! lemme get rid of these bad urls as well |
mattmakai
added a commit
that referenced
this pull request
Jan 8, 2019
mattmakai
added a commit
that referenced
this pull request
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New output:
It intends to provide correlation between bad urls and the content that contains those bad urls. Since a bad url can exist in multiple files, the locations output is shown in terms of a Python list instead of a Python string.