Add TypeVarTupleExpr node #12481
Merged
Add TypeVarTupleExpr node #12481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
| ) | ||
|
|
||
|
|
||
| class TypeVarTupleExpr(TypeVarLikeExpr): |
Collaborator
There was a problem hiding this comment.
add docstring for this and also modify the docstring of TypeVarLikeExpr
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Mar 29, 2022
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Looks good, just left a few ideas further tests. Feel free to merge after you've updated tests.
|
|
||
| TVariadic = TypeVarTuple('TVariadic') | ||
| TP = TypeVarTuple('?') # E: String argument 1 "?" to TypeVarTuple(...) does not match variable name "TP" | ||
| TP2: int = TypeVarTuple('TP2') # E: Cannot declare the type of a TypeVar or similar construct |
Collaborator
There was a problem hiding this comment.
Also test calling TypeVarTuple with no args, too many args, and keyword args (all should be disallowed).
| from typing import Tuple | ||
|
|
||
| heterogenous_tuple: Tuple[Unpack[Tuple[int, str]]] | ||
| homogenous_tuple: Tuple[Unpack[Tuple[int, ...]]] |
Collaborator
There was a problem hiding this comment.
Also add at least one AST dump test case to test-data/unit/semanal-types.test.
Collaborator
|
Also flake8 is failing. |
Collaborator
Author
|
Yeah the flakr8 started falling when I updated the docstrings |
This adds minimal support for a TypeVarTupleExpr node, gated behind the flag to enable incomplete features. It is modeled after paramspec, including the part where we don't support the various arguments that have no behavior defined in PEP646. We also include TypeVarTuple in the typing_extensions stubs for test data and add some very basic semanal tests to verify the basic things work.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds minimal support for a TypeVarTupleExpr node, gated behind the
flag to enable incomplete features. It is modeled after paramspec,
including the part where we don't support the various arguments that
have no behavior defined in PEP646.
We also include TypeVarTuple in the typing_extensions stubs for test
data and add some very basic semanal tests to verify the basic things work.